Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 696633002: Merge 183823 "Ignore continuations when collapsing an anonymous ..." (Closed)

Created:
6 years, 1 month ago by mstensho (USE GERRIT)
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Merge 183823 "Ignore continuations when collapsing an anonymous ..." > Ignore continuations when collapsing an anonymous block. > > When we decide to promote all children of an anonymous block and then > nuke it, ignore any continuation set on the new parent of the children, > to make sure that the children are in fact inserted as children of said > new parent, and not somewhere else in the tree. > > This is a hack that's needed as long as we keep the old multicol > implementation. The root cause is probably buggy block continuation > handling, but fixing that would be risky. > > BUG=421720 > > Review URL: https://codereview.chromium.org/656143003 TBR=mstensho@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, --2 lines) Patch
A + LayoutTests/fast/multicol/nested-multicol-two-spanners-dynamic.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/multicol/nested-multicol-two-spanners-dynamic-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mstensho (USE GERRIT)
6 years, 1 month ago (2014-10-31 09:17:20 UTC) #1
mstensho (USE GERRIT)
6 years, 1 month ago (2014-10-31 09:17:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r184703.

Powered by Google App Engine
This is Rietveld 408576698