Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: chromeos/network/network_state_handler.h

Issue 696583004: Add NetworkHandler support for WakeOnLanEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/network/network_state_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 6fd92a3273743d46d502a889d31f77ca1e17d9e5..782e6921494fd631d209bf32315b75fd7d1eacd9 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -191,15 +191,15 @@ class CHROMEOS_EXPORT NetworkStateHandler
// list, which will trigger the appropriate observer calls.
void RequestScan() const;
- // Request a scan if not scanning and run |callback| when the Scanning state
+ // Requests a scan if not scanning and run |callback| when the Scanning state
michaelpg 2014/10/31 19:15:28 runs
stevenjb 2014/10/31 19:27:16 Done.
// for any Device of network type |type| completes.
void WaitForScan(const std::string& type, const base::Closure& callback);
- // Request a network scan then signal Shill to connect to the best available
+ // Requests a network scan then signal Shill to connect to the best available
michaelpg 2014/10/31 19:15:28 signals
stevenjb 2014/10/31 19:27:16 Done.
// networks when completed.
void ConnectToBestWifiNetwork();
- // Request an update for an existing NetworkState, e.g. after configuring
+ // Requests an update for an existing NetworkState, e.g. after configuring
// a network. This is a no-op if an update request is already pending. To
// ensure that a change is picked up, this must be called after Shill
// acknowledged it (e.g. in the callback of a SetProperties).
@@ -208,12 +208,16 @@ class CHROMEOS_EXPORT NetworkStateHandler
// properties actually changed.
void RequestUpdateForNetwork(const std::string& service_path);
- // Clear the last_error value for the NetworkState for |service_path|.
+ // Clears the last_error value for the NetworkState for |service_path|.
void ClearLastErrorForNetwork(const std::string& service_path);
- // Set the list of devices on which portal check is enabled.
+ // Sets the list of devices on which portal check is enabled.
void SetCheckPortalList(const std::string& check_portal_list);
+ // Sets the Manager.WakeOnLan property. Note: we do not track this state, we
+ // only set it.
+ void SetWakeOnLanEnabled(bool enabled);
+
const std::string& GetCheckPortalListForTest() const {
return check_portal_list_;
}
@@ -228,7 +232,7 @@ class CHROMEOS_EXPORT NetworkStateHandler
return default_network_path_;
}
- // Construct and initialize an instance for testing.
+ // Constructs and initializes an instance for testing.
static NetworkStateHandler* InitializeForTest();
// Default set of comma separated interfaces on which to enable
« no previous file with comments | « no previous file | chromeos/network/network_state_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698