Add NetworkHandler support for WakeOnLanEnabled

Add NetworkHandler support for WakeOnLanEnabled

BUG=427605
Committed: https://crrev.com/19d23372e54437f91257276b60fcc3f244301be5
Cr-Commit-Position: refs/heads/master@{#302317}

[stevenjb, 2014-10-31 18:27:23]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2014-10-31 19:15:28]

please excuse my ignorance... Why do calls like this or the existing
SetCheckPortalList need to go through NetworkStateHandler, when they're not
specific to one network? Is this just a convenient way to expose the
ShillManagerClient to the rest of Chrome?

https://codereview.chromium.org/696583004/diff/1/chromeos/network/network_sta...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/696583004/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:194: // Requests a scan if not scanning
and run |callback| when the Scanning state
runs

https://codereview.chromium.org/696583004/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:198: // Requests a network scan then
signal Shill to connect to the best available
signals

[stevenjb, 2014-10-31 19:24:25]

On 2014/10/31 19:15:28, michaelpg wrote:
> please excuse my ignorance... Why do calls like this or the existing
> SetCheckPortalList need to go through NetworkStateHandler, when they're not
> specific to one network? Is this just a convenient way to expose the
> ShillManagerClient to the rest of Chrome?
> 
Correct. The layering looks like:
NetworkStateHandler - public API
ShillPropertyHandler - private ShillManagerClient interface for NSH
ShillManagerClient - DBus API for Shill.Manager

We don't track a "Manager" object. We may want to add that at some point, but
Shill doesn't persist any global state, so for now NSH is a convenient API for
the few global setters.

[michaelpg, 2014-10-31 19:25:30]

On 2014/10/31 19:24:25, stevenjb wrote:
> On 2014/10/31 19:15:28, michaelpg wrote:
> > please excuse my ignorance... Why do calls like this or the existing
> > SetCheckPortalList need to go through NetworkStateHandler, when they're not
> > specific to one network? Is this just a convenient way to expose the
> > ShillManagerClient to the rest of Chrome?
> > 
> Correct. The layering looks like:
> NetworkStateHandler - public API
> ShillPropertyHandler - private ShillManagerClient interface for NSH
> ShillManagerClient - DBus API for Shill.Manager
> 
> We don't track a "Manager" object. We may want to add that at some point, but
> Shill doesn't persist any global state, so for now NSH is a convenient API for
> the few global setters.

Cool. lgtm with grammar nits.

[stevenjb, 2014-10-31 19:27:17]

https://codereview.chromium.org/696583004/diff/1/chromeos/network/network_sta...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/696583004/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:194: // Requests a scan if not scanning
and run |callback| when the Scanning state
On 2014/10/31 19:15:28, michaelpg wrote:
> runs

Done.

https://codereview.chromium.org/696583004/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:198: // Requests a network scan then
signal Shill to connect to the best available
On 2014/10/31 19:15:28, michaelpg wrote:
> signals

Done.

[stevenjb, 2014-10-31 19:28:28]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-10-31 19:29:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696583004/20001

[commit-bot: I haz the power, 2014-10-31 20:27:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-31 20:28:09]

Patchset 2 (id:??) landed as
https://crrev.com/19d23372e54437f91257276b60fcc3f244301be5
Cr-Commit-Position: refs/heads/master@{#302317}