Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Unified Diff: mojo/shell/dynamic_application_loader.cc

Issue 696563002: Cache ShellImpl by resolved URL, not initial URL (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/context.cc ('k') | mojo/shell/external_application_listener_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/dynamic_application_loader.cc
diff --git a/mojo/shell/dynamic_application_loader.cc b/mojo/shell/dynamic_application_loader.cc
index 3f5eaba0ae60ca2f2e9c84aa56ee7526adbe11eb..e2e07da90572a4535352a68f4a760974cf2ac3ab 100644
--- a/mojo/shell/dynamic_application_loader.cc
+++ b/mojo/shell/dynamic_application_loader.cc
@@ -264,15 +264,8 @@ void DynamicApplicationLoader::Load(
ApplicationManager* manager,
const GURL& url,
scoped_refptr<LoadCallbacks> load_callbacks) {
- GURL resolved_url;
- if (url.SchemeIs("mojo")) {
- resolved_url = context_->mojo_url_resolver()->Resolve(url);
- } else {
- resolved_url = url;
- }
-
- if (resolved_url.SchemeIsFile()) {
- loaders_.push_back(new LocalLoader(resolved_url,
+ if (url.SchemeIsFile()) {
+ loaders_.push_back(new LocalLoader(url,
context_,
runner_factory_.get(),
load_callbacks,
@@ -285,7 +278,7 @@ void DynamicApplicationLoader::Load(
GURL("mojo:network_service"), &network_service_);
}
- loaders_.push_back(new NetworkLoader(resolved_url,
+ loaders_.push_back(new NetworkLoader(url,
&mime_type_to_url_,
context_,
runner_factory_.get(),
« no previous file with comments | « mojo/shell/context.cc ('k') | mojo/shell/external_application_listener_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698