Cache ShellImpl by resolved URL, not initial URL

mojo/application_manager/application_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/application_manager/application_manager.h"
 
 #include <stdio.h>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 17 matching lines @@
  public:
   ServiceProvider* GetRemoteServiceProvider() { return client(); }
 
  private:
   void ConnectToService(const String& service_name,
                         ScopedMessagePipeHandle client_handle) override {}
 };
 
 }  // namespace
 
-ApplicationManager::Delegate::~Delegate() {}
+
+ApplicationManager::Delegate::~Delegate() {
+}
+
+void ApplicationManager::Delegate::OnApplicationError(const GURL& url) {
+  LOG(ERROR) << "Communication error with application: " << url.spec();
+}
+
+GURL ApplicationManager::Delegate::ResolveURL(const GURL& url) {
+  return url;
+}
+
 
 class ApplicationManager::LoadCallbacksImpl
     : public ApplicationLoader::LoadCallbacks {
  public:
   LoadCallbacksImpl(base::WeakPtr<ApplicationManager> manager,
                     const GURL& requested_url,
+                    const GURL& resolved_url,
                     const GURL& requestor_url,
                     ServiceProviderPtr service_provider)
       : manager_(manager),
         requested_url_(requested_url),
+        resolved_url_(resolved_url),
         requestor_url_(requestor_url),
         service_provider_(service_provider.Pass()) {}
 
  private:
   ~LoadCallbacksImpl() override {}
 
   // LoadCallbacks implementation
   ScopedMessagePipeHandle RegisterApplication() override {
     ScopedMessagePipeHandle shell_handle;
     if (manager_) {
       manager_->RegisterLoadedApplication(requested_url_,
+                                          resolved_url_,
                                           requestor_url_,
                                           service_provider_.Pass(),
                                           &shell_handle);
     }
     return shell_handle.Pass();
   }
 
   void LoadWithContentHandler(const GURL& content_handler_url,
                               URLResponsePtr url_response) override {
     if (manager_) {
       manager_->LoadWithContentHandler(requested_url_,
                                        requestor_url_,
                                        content_handler_url,
                                        url_response.Pass(),
                                        service_provider_.Pass());
     }
   }
 
   base::WeakPtr<ApplicationManager> manager_;
   GURL requested_url_;
+  GURL resolved_url_;
   GURL requestor_url_;
   ServiceProviderPtr service_provider_;
 };
 
 class ApplicationManager::ShellImpl : public InterfaceImpl<Shell> {
  public:
-  ShellImpl(ApplicationManager* manager, const GURL& url)
-      : manager_(manager), url_(url) {}
+  ShellImpl(ApplicationManager* manager, const GURL& requested_url,

[DaveMoore, 2014/10/31 16:15:58]

Nit: could you put these on their own lines?

[Aaron Boodman, 2014/10/31 18:14:02]

Done.

+            const GURL& url)
+      : manager_(manager), requested_url_(requested_url), url_(url) {}
 
   ~ShellImpl() override {}
 
   void ConnectToClient(const GURL& requestor_url,
                        ServiceProviderPtr service_provider) {
     client()->AcceptConnection(String::From(requestor_url),
                                service_provider.Pass());
   }
 
   // ServiceProvider implementation:
   void ConnectToApplication(
       const String& app_url,
       InterfaceRequest<ServiceProvider> in_service_provider) override {
     ServiceProviderPtr out_service_provider;
     out_service_provider.Bind(in_service_provider.PassMessagePipe());
     manager_->ConnectToApplication(
         app_url.To<GURL>(), url_, out_service_provider.Pass());
   }
 
   const GURL& url() const { return url_; }
+  const GURL& requested_url() const { return requested_url_; }
 
  private:
   void OnConnectionError() override { manager_->OnShellImplError(this); }
 
   ApplicationManager* const manager_;
+  const GURL requested_url_;
   const GURL url_;
 
   DISALLOW_COPY_AND_ASSIGN(ShellImpl);
 };
 
 struct ApplicationManager::ContentHandlerConnection {
   ContentHandlerConnection(ApplicationManager* manager,
                            const GURL& content_handler_url) {
     ServiceProviderPtr service_provider;
     BindToProxy(&service_provider_impl, &service_provider);
@@ skipping 16 matching lines @@
 
 bool ApplicationManager::TestAPI::HasCreatedInstance() {
   return has_created_instance;
 }
 
 bool ApplicationManager::TestAPI::HasFactoryForURL(const GURL& url) const {
   return manager_->url_to_shell_impl_.find(url) !=
          manager_->url_to_shell_impl_.end();
 }
 
-ApplicationManager::ApplicationManager()
-    : delegate_(NULL),
+ApplicationManager::ApplicationManager(Delegate* delegate)
+    : delegate_(delegate),
       interceptor_(NULL),
       weak_ptr_factory_(this) {
 }
 
 ApplicationManager::~ApplicationManager() {
   STLDeleteValues(&url_to_content_handler_);
   TerminateShellConnections();
   STLDeleteValues(&url_to_loader_);
   STLDeleteValues(&scheme_to_loader_);
 }
 
 void ApplicationManager::TerminateShellConnections() {
   STLDeleteValues(&url_to_shell_impl_);
 }
 
-// static
-ApplicationManager* ApplicationManager::GetInstance() {
-  static base::LazyInstance<ApplicationManager> instance =
-      LAZY_INSTANCE_INITIALIZER;
-  has_created_instance = true;
-  return &instance.Get();
-}
-
 void ApplicationManager::ConnectToApplication(
-    const GURL& url,
+    const GURL& requested_url,
     const GURL& requestor_url,
     ServiceProviderPtr service_provider) {
-  URLToShellImplMap::const_iterator shell_it = url_to_shell_impl_.find(url);
+  GURL resolved_url = delegate_->ResolveURL(requested_url);
+
+  URLToShellImplMap::const_iterator shell_it =
+      url_to_shell_impl_.find(resolved_url);
   if (shell_it != url_to_shell_impl_.end()) {
-    ConnectToClient(
-        shell_it->second, url, requestor_url, service_provider.Pass());
+    ConnectToClient(shell_it->second, resolved_url, requestor_url,
+                    service_provider.Pass());
     return;
   }
 
   scoped_refptr<LoadCallbacksImpl> callbacks(
       new LoadCallbacksImpl(weak_ptr_factory_.GetWeakPtr(),
-                            url,
+                            requested_url,
+                            resolved_url,
                             requestor_url,
                             service_provider.Pass()));
-  GetLoaderForURL(url)->Load(this, url, callbacks);
+  GetLoaderForURL(resolved_url)->Load(this, resolved_url, callbacks);
 }
 
 void ApplicationManager::ConnectToClient(ShellImpl* shell_impl,
                                          const GURL& url,
                                          const GURL& requestor_url,
                                          ServiceProviderPtr service_provider) {
   if (interceptor_) {
     shell_impl->ConnectToClient(
         requestor_url,
         interceptor_->OnConnectToClient(url, service_provider.Pass()));
   } else {
     shell_impl->ConnectToClient(requestor_url, service_provider.Pass());
   }
 }
 
 void ApplicationManager::RegisterExternalApplication(
     const GURL& url,
     ScopedMessagePipeHandle shell_handle) {
   url_to_shell_impl_[url] =
-      WeakBindToPipe(new ShellImpl(this, url), shell_handle.Pass());
+      WeakBindToPipe(new ShellImpl(this, url, url), shell_handle.Pass());
 }
 
 void ApplicationManager::RegisterLoadedApplication(
-    const GURL& url,
+    const GURL& requested_url,
+    const GURL& resolved_url,
     const GURL& requestor_url,
     ServiceProviderPtr service_provider,
     ScopedMessagePipeHandle* shell_handle) {
   ShellImpl* shell_impl = NULL;
-  URLToShellImplMap::iterator iter = url_to_shell_impl_.find(url);
+  URLToShellImplMap::iterator iter = url_to_shell_impl_.find(resolved_url);
   if (iter != url_to_shell_impl_.end()) {
     // This can happen because services are loaded asynchronously. So if we get
     // two requests for the same service close to each other, we might get here
     // and find that we already have it.
     shell_impl = iter->second;
   } else {
     MessagePipe pipe;
-    URLToArgsMap::const_iterator args_it = url_to_args_.find(url);
+    URLToArgsMap::const_iterator args_it = url_to_args_.find(resolved_url);
     Array<String> args;
     if (args_it != url_to_args_.end())
       args = Array<String>::From(args_it->second);
-    shell_impl = WeakBindToPipe(new ShellImpl(this, url), pipe.handle1.Pass());
-    url_to_shell_impl_[url] = shell_impl;
+    shell_impl = WeakBindToPipe(
+        new ShellImpl(this, requested_url, resolved_url), pipe.handle1.Pass());
+    url_to_shell_impl_[resolved_url] = shell_impl;
     *shell_handle = pipe.handle0.Pass();
     shell_impl->client()->Initialize(args.Pass());
   }
 
-  ConnectToClient(shell_impl, url, requestor_url, service_provider.Pass());
+  ConnectToClient(shell_impl, resolved_url, requestor_url,
+                  service_provider.Pass());
 }
 
 void ApplicationManager::LoadWithContentHandler(
     const GURL& content_url,
     const GURL& requestor_url,
     const GURL& content_handler_url,
     URLResponsePtr url_response,
     ServiceProviderPtr service_provider) {
   ContentHandlerConnection* connection = NULL;
   URLToContentHandlerMap::iterator iter =
@@ skipping 44 matching lines @@
   SchemeToLoaderMap::const_iterator scheme_it =
       scheme_to_loader_.find(url.scheme());
   if (scheme_it != scheme_to_loader_.end())
     return scheme_it->second;
   return default_loader_.get();
 }
 
 void ApplicationManager::OnShellImplError(ShellImpl* shell_impl) {
   // Called from ~ShellImpl, so we do not need to call Destroy here.
   const GURL url = shell_impl->url();
+  const GURL requested_url = shell_impl->requested_url();
   URLToShellImplMap::iterator it = url_to_shell_impl_.find(url);
   DCHECK(it != url_to_shell_impl_.end());
   delete it->second;
   url_to_shell_impl_.erase(it);
-  ApplicationLoader* loader = GetLoaderForURL(url);
+  ApplicationLoader* loader = GetLoaderForURL(requested_url);
   if (loader)
     loader->OnApplicationError(this, url);
-  if (delegate_)
-    delegate_->OnApplicationError(url);
+  delegate_->OnApplicationError(requested_url);
 }
 
 ScopedMessagePipeHandle ApplicationManager::ConnectToServiceByName(
     const GURL& application_url,
     const std::string& interface_name) {
   StubServiceProvider* stub_sp = new StubServiceProvider;
   ServiceProviderPtr spp;
   BindToProxy(stub_sp, &spp);
   ConnectToApplication(application_url, GURL(), spp.Pass());
   MessagePipe pipe;
   stub_sp->GetRemoteServiceProvider()->ConnectToService(interface_name,
                                                         pipe.handle1.Pass());
   return pipe.handle0.Pass();
 }
 }  // namespace mojo