Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 696543002: Move the chrome.management API to extensions. (Closed)

Created:
6 years, 1 month ago by lfg
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, sadrul, tfarina, kalyank, chromium-apps-reviews_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the chrome.management API to extensions. BUG=422618 Committed: https://crrev.com/3fba1a6a4f245a326d7221b031a9bf599c0c5874 Cr-Commit-Position: refs/heads/master@{#302681}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+906 lines, -2293 lines) Patch
M chrome/browser/chromeos/first_run/first_run.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/management/chrome_management_api_delegate.h View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 1 2 1 chunk +389 lines, -0 lines 0 comments Download
D chrome/browser/extensions/api/management/management_api.h View 1 chunk +0 lines, -309 lines 0 comments Download
D chrome/browser/extensions/api/management/management_api.cc View 1 chunk +0 lines, -1023 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/management/management_api_constants.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/extensions/api/management/management_api_constants.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_sync_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/launch_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/common/extensions/api/management.json View 1 chunk +0 lines, -437 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_launch_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + extensions/browser/api/management/management_api.h View 8 chunks +37 lines, -54 lines 0 comments Download
A + extensions/browser/api/management/management_api.cc View 1 2 33 chunks +182 lines, -306 lines 0 comments Download
A + extensions/browser/api/management/management_api_constants.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + extensions/browser/api/management/management_api_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A extensions/browser/api/management/management_api_delegate.h View 1 chunk +128 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/browser_context_keyed_service_factories.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 chunk +19 lines, -0 lines 0 comments Download
A + extensions/common/api/management.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/constants.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lfg
Hi Ken, can you take a look? This is a first pass, it only moves ...
6 years, 1 month ago (2014-10-30 23:52:57 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/696543002/diff/20001/chrome/browser/extensions/api/management/chrome_management_api_delegate.h File chrome/browser/extensions/api/management/chrome_management_api_delegate.h (right): https://codereview.chromium.org/696543002/diff/20001/chrome/browser/extensions/api/management/chrome_management_api_delegate.h#newcode17 chrome/browser/extensions/api/management/chrome_management_api_delegate.h:17: namespace extensions { nit: I'd like to stop ...
6 years, 1 month ago (2014-11-03 17:22:57 UTC) #3
lfg
sky@chromium.org: Please review changes in chrome/browser/chromeos/first_run/first_run.cc chrome/browser/ui/app_list/app_list_controller_delegate.h chrome/browser/ui/ash/launcher/chrome_launcher_controller.h chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
6 years, 1 month ago (2014-11-04 17:38:33 UTC) #5
lfg
On 2014/11/03 17:22:57, Ken Rockot wrote: > lgtm > > https://codereview.chromium.org/696543002/diff/20001/chrome/browser/extensions/api/management/chrome_management_api_delegate.h > File chrome/browser/extensions/api/management/chrome_management_api_delegate.h > ...
6 years, 1 month ago (2014-11-04 17:38:57 UTC) #6
sky
Said files LGTM
6 years, 1 month ago (2014-11-04 18:16:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696543002/40001
6 years, 1 month ago (2014-11-04 21:23:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-04 22:26:59 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:27:42 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3fba1a6a4f245a326d7221b031a9bf599c0c5874
Cr-Commit-Position: refs/heads/master@{#302681}

Powered by Google App Engine
This is Rietveld 408576698