Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 696503004: Some distance field text optimizations. (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Some distance field text optimizations. - Add clipRect check - Remove creation of scalerContext to check for color fonts in canDraw() (no longer needed) BUG=skia:2933 Committed: https://skia.googlesource.com/skia/+/2faa2284357d7cec51b26d8251c53bc91251b1fe

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix Windows compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -40 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 5 chunks +26 lines, -40 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jvanverth1
6 years, 1 month ago (2014-10-31 18:55:07 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/696503004/diff/1/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/696503004/diff/1/src/gpu/GrDistanceFieldTextContext.cpp#newcode484 src/gpu/GrDistanceFieldTextContext.cpp:484: const SkMatrix& ctm = fContext->getMatrix(); Is there anything ...
6 years, 1 month ago (2014-10-31 19:09:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696503004/1
6 years, 1 month ago (2014-10-31 19:22:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/476)
6 years, 1 month ago (2014-10-31 19:40:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696503004/20001
6 years, 1 month ago (2014-10-31 19:52:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696503004/20001
6 years, 1 month ago (2014-10-31 19:52:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 20:00:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 2faa2284357d7cec51b26d8251c53bc91251b1fe

Powered by Google App Engine
This is Rietveld 408576698