Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 696503002: [Android] Use the Activity context for content selection handles (Closed)

Created:
6 years, 1 month ago by jdduke (slow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Use the Activity context for content selection handles Using the Activity context ensures the content-targetted selection handles use a theme consistent with the rest of Chrome's UI. Committed: https://crrev.com/7119263a2f94aaf3af6351f4fd5135a6c75947d9 Cr-Commit-Position: refs/heads/master@{#302181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jdduke (slow)
tedchoc@: PTAL, thanks.
6 years, 1 month ago (2014-10-30 20:36:13 UTC) #2
Ted C
lgtm
6 years, 1 month ago (2014-10-30 21:25:02 UTC) #3
jdduke (slow)
+aelias@ as render_widget_host_view_android.cc owner.
6 years, 1 month ago (2014-10-30 21:36:33 UTC) #7
aelias_OOO_until_Jul13
lgtm
6 years, 1 month ago (2014-10-30 21:49:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696503002/1
6 years, 1 month ago (2014-10-30 22:05:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 22:54:31 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 22:55:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7119263a2f94aaf3af6351f4fd5135a6c75947d9
Cr-Commit-Position: refs/heads/master@{#302181}

Powered by Google App Engine
This is Rietveld 408576698