Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 696383002: bookmarks: unclip dnd separator. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

bookmarks: unclip dnd separator. Also removes white cruft on top and bottom of #list while scrolling. R=arv@chromium.org BUG=429591 Committed: https://crrev.com/e8f49e1d8ea6b688368b4c233690681abe4d11bd Cr-Commit-Position: refs/heads/master@{#302474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
6 years, 1 month ago (2014-11-03 19:53:39 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 1 month ago (2014-11-03 20:00:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696383002/1
6 years, 1 month ago (2014-11-03 20:03:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 20:45:32 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 20:46:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8f49e1d8ea6b688368b4c233690681abe4d11bd
Cr-Commit-Position: refs/heads/master@{#302474}

Powered by Google App Engine
This is Rietveld 408576698