Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 696353003: cc: Handle GrContext::wrapBackendTexture failures properly. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
piman, alokp
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Handle GrContext::wrapBackendTexture failures properly. GrContext::wrapBackendTexture will return null in case of failure but the compositor assumes that this will never happen. This will make GetSkSurface early out if the return value of GrContext::wrapBackendTexture is null. BUG=419136 Committed: https://crrev.com/00f53a49a90a56c22d412a8e0e27e3a4a6ae5155 Cr-Commit-Position: refs/heads/master@{#302477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/resources/resource_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
6 years, 1 month ago (2014-11-03 19:09:29 UTC) #2
piman
lgtm
6 years, 1 month ago (2014-11-03 19:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696353003/1
6 years, 1 month ago (2014-11-03 19:17:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 20:57:01 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 20:57:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00f53a49a90a56c22d412a8e0e27e3a4a6ae5155
Cr-Commit-Position: refs/heads/master@{#302477}

Powered by Google App Engine
This is Rietveld 408576698