Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 696353002: Test factory uses the inorder draw buffer (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Test factory uses the inorder draw buffer BUG=skia: Committed: https://skia.googlesource.com/skia/+/50408adfd23994cdbb5c531ff6366e4e9d29ee6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -30 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/beziereffects.cpp View 6 chunks +30 lines, -24 lines 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +12 lines, -4 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
Test failures are unrelated to this change. I will try and delete the setVertexCallToArray after
6 years, 1 month ago (2014-11-03 17:56:01 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-03 18:34:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696353002/1
6 years, 1 month ago (2014-11-03 20:22:20 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 20:31:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 50408adfd23994cdbb5c531ff6366e4e9d29ee6d

Powered by Google App Engine
This is Rietveld 408576698