Issue 69633003: Fix a memory leak in SkGPipeCanvas.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69633003: Fix a memory leak in SkGPipeCanvas. (Closed)

Created:
7 years, 1 month ago by scroggo

Modified:
7 years, 1 month ago

Reviewers:
Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix a memory leak in SkGPipeCanvas. In cross process mode (currently unused but tested on the bots), SkGPipeCanvas has a tangle of circular references, which prevents it from being deleted. Break the chain of references. R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=12237

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -47 lines)			Patch
	M	src/pipe/SkGPipeWrite.cpp	View		8 chunks	+71 lines, -47 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

Wow, this must have been fun to debug (sarcasm). Thanks for the clear explanation in ...

7 years, 1 month ago (2013-11-12 02:42:02 UTC) #2

scroggo

7 years, 1 month ago (2013-11-12 14:32:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r12237 (presubmit successful).

Expand Messages | Collapse Messages