Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 69633002: Mojo: Add BindingsSupportImpl on top of HandleWatcher (take 2) (Closed)

Created:
7 years, 1 month ago by darin (slow to review)
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add BindingsSupportImpl on top of HandleWatcher (take 2) Plumb MojoResult to the callback set on HandleWatcher. Revise BindingsSupport interface to make the implementation on top of HandleWatcher trivial. Originally reviewed at https://codereview.chromium.org/62773003/. Includes fix to mojo.gyp to make libmojo_shell link against mojo_common_lib on Android. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -81 lines) Patch
A mojo/common/bindings_support_impl.h View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/common/bindings_support_impl.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M mojo/common/handle_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/common/handle_watcher.cc View 7 chunks +15 lines, -11 lines 0 comments Download
M mojo/common/handle_watcher_unittest.cc View 3 chunks +30 lines, -3 lines 0 comments Download
M mojo/mojo.gyp View 4 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/bindings/lib/bindings_support.h View 1 chunk +18 lines, -10 lines 0 comments Download
M mojo/public/bindings/lib/connector.h View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/public/bindings/lib/connector.cc View 5 chunks +16 lines, -25 lines 0 comments Download
M mojo/public/tests/simple_bindings_support.h View 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/public/tests/simple_bindings_support.cc View 1 chunk +26 lines, -21 lines 0 comments Download
M mojo/shell/context.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/context.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
LGTM
7 years, 1 month ago (2013-11-11 23:52:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/69633002/1
7 years, 1 month ago (2013-11-12 00:53:48 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=188138
7 years, 1 month ago (2013-11-12 01:40:16 UTC) #3
darin (slow to review)
7 years, 1 month ago (2013-11-12 05:10:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r234408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698