Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 696283002: Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (Closed)

Created:
6 years, 1 month ago by v8-autoroll
Modified:
6 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). TBR=machenbach@chromium.org Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4 Cr-Commit-Position: refs/heads/master@{#302437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
v8-autoroll
6 years, 1 month ago (2014-11-03 15:43:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696283002/1
6 years, 1 month ago (2014-11-03 15:43:46 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-03 15:43:49 UTC) #5
Michael Achenbach
lgtm
6 years, 1 month ago (2014-11-03 15:46:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696283002/1
6 years, 1 month ago (2014-11-03 15:46:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 16:44:42 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4 Cr-Commit-Position: refs/heads/master@{#302437}
6 years, 1 month ago (2014-11-03 16:45:25 UTC) #10
Mike Lerman
6 years, 1 month ago (2014-11-03 19:00:06 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/686683005/ by mlerman@chromium.org.

The reason for reverting is: Common CL assumed to be causing Android Tests to
fail:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/1...
and
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698