Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 696233002: Make blink_heap_unittests link in static_library Debug builds on Windows (Closed)

Created:
6 years, 1 month ago by hans
Modified:
6 years, 1 month ago
Reviewers:
Nico, Stephen White
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make blink_heap_unittests link in static_library Debug builds on Windows It was failing to link due to multiple definitions of memory allocation functions (in both 32- and 64-bit builds). It seems we don't have any buildbots exercising this configuration. BUG=429498 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/platform/blink_platform_tests.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hans
Please take a look.
6 years, 1 month ago (2014-11-03 10:03:16 UTC) #2
Nico
lgtm, thanks!
6 years, 1 month ago (2014-11-03 15:11:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696233002/1
6 years, 1 month ago (2014-11-03 15:12:23 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 17:01:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184793

Powered by Google App Engine
This is Rietveld 408576698