Issue 696223002: Now with more checkings! Skip the CallFunctionStub when the callee function can be statically deter…

Issue 696223002: Now with more checkings! Skip the CallFunctionStub when the callee function can be statically deter… (Closed)

Created:
6 years, 1 month ago by titzer

Modified:
6 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Now with more checkings! Skip the CallFunctionStub when the callee function can be statically determined. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25062

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -66 lines)			Patch
M	src/compiler/arm/linkage-arm.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/arm64/linkage-arm64.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/ia32/linkage-ia32.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/js-generic-lowering.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/js-generic-lowering.cc	View	2 chunks	+49 lines, -7 lines	1 comment	Download
M	src/compiler/linkage.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/compiler/linkage.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/compiler/linkage-impl.h	View	5 chunks	+45 lines, -41 lines	0 comments	Download
M	src/compiler/mips/linkage-mips.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/raw-machine-assembler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/x64/linkage-x64.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/cctest/compiler/test-linkage.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (reviewed generic lowering, rubber-stamped the rest). https://codereview.chromium.org/696223002/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/696223002/diff/1/src/compiler/js-generic-lowering.cc#newcode447 src/compiler/js-generic-lowering.cc:447: if (!TryLowerDirectJSCall(node)) ...

6 years, 1 month ago (2014-11-03 09:57:41 UTC) #2

titzer

On 2014/11/03 09:57:41, Michael Starzinger wrote: > LGTM (reviewed generic lowering, rubber-stamped the rest). > ...

6 years, 1 month ago (2014-11-03 10:00:30 UTC) #3

titzer

6 years, 1 month ago (2014-11-03 10:22:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25062 (presubmit successful).

Expand Messages | Collapse Messages