Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 6962035: Build pyautolib target under clang (Closed)

Created:
9 years, 7 months ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, dyu1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Build pyautolib target under clang Fixed some genuine problems. Passed -Wno-self-assign for a problem in a generated code (pyautolib_wrap.cc) R=thakis@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86983

Patch Set 1 #

Patch Set 2 : remove virtual #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 2 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nirnimesh
9 years, 7 months ago (2011-05-27 02:35:08 UTC) #1
Nico
Thanks! One comment. http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi#newcode3730 chrome/chrome_tests.gypi:3730: '-Wno-self-assign', # to keep clang happy ...
9 years, 7 months ago (2011-05-27 02:37:57 UTC) #2
Nirnimesh
http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi#newcode3730 chrome/chrome_tests.gypi:3730: '-Wno-self-assign', # to keep clang happy for generated code. ...
9 years, 7 months ago (2011-05-27 06:31:16 UTC) #3
Nico
9 years, 7 months ago (2011-05-27 06:34:20 UTC) #4
LGTM

On Thu, May 26, 2011 at 11:31 PM,  <nirnimesh@chromium.org> wrote:
>
> http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi
> File chrome/chrome_tests.gypi (right):
>
>
http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi#new...
> chrome/chrome_tests.gypi:3730: '-Wno-self-assign',  # to keep clang
> happy for generated code.
> On 2011/05/27 02:37:57, Nico wrote:
>>
>> Does gcc understand this flag? If not, this will break the gcc build
>
> (in that
>>
>> case, this branch needs to go in a conditions 'clang=1' block)
>
> Try jobs with this CL have passed.
> Linux:
> http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/29085
> Mac:
> http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/29338
> Win:
> http://build.chromium.org/p/tryserver.chromium/builders/win/builds/33962
>
>
>> You probably need to add this to xcode_settings below as well (look
>
> for
>>
>> other_cflags in build/common.gypi on how to add raw flags to xcode
>
> configs)
>
> This is not a problem on Mac anyway since 'GCC_TREAT_WARNINGS_AS_ERRORS'
> used below is equivalent to -Wno-error, which supersedes
> -Wno-self-assign
>
> http://codereview.chromium.org/6962035/
>

Powered by Google App Engine
This is Rietveld 408576698