Build pyautolib target under clang

Build pyautolib target under clang

Fixed some genuine problems.
Passed -Wno-self-assign for a problem in a generated code (pyautolib_wrap.cc)


R=thakis@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86983

[Nico, 2011-05-27 02:37:57]

Thanks! One comment.

http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:3730: '-Wno-self-assign',  # to keep clang happy for
generated code.
Does gcc understand this flag? If not, this will break the gcc build (in that
case, this branch needs to go in a conditions 'clang=1' block)

You probably need to add this to xcode_settings below as well (look for
other_cflags in build/common.gypi on how to add raw flags to xcode configs)

[Nirnimesh, 2011-05-27 06:31:16]

http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:3730: '-Wno-self-assign',  # to keep clang happy for
generated code.
On 2011/05/27 02:37:57, Nico wrote:
> Does gcc understand this flag? If not, this will break the gcc build (in that
> case, this branch needs to go in a conditions 'clang=1' block)

Try jobs with this CL have passed.
Linux:
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/29085
Mac: http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/29338
Win: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/33962

> 
> You probably need to add this to xcode_settings below as well (look for
> other_cflags in build/common.gypi on how to add raw flags to xcode configs)

This is not a problem on Mac anyway since 'GCC_TREAT_WARNINGS_AS_ERRORS' used
below is equivalent to -Wno-error, which supersedes -Wno-self-assign

[Nico, 2011-05-27 06:34:20]

LGTM

On Thu, May 26, 2011 at 11:31 PM,  <nirnimesh@chromium.org> wrote:
>
> http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi
> File chrome/chrome_tests.gypi (right):
>
>
http://codereview.chromium.org/6962035/diff/2001/chrome/chrome_tests.gypi#new...
> chrome/chrome_tests.gypi:3730: '-Wno-self-assign',  # to keep clang
> happy for generated code.
> On 2011/05/27 02:37:57, Nico wrote:
>>
>> Does gcc understand this flag? If not, this will break the gcc build
>
> (in that
>>
>> case, this branch needs to go in a conditions 'clang=1' block)
>
> Try jobs with this CL have passed.
> Linux:
> http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/29085
> Mac:
> http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/29338
> Win:
> http://build.chromium.org/p/tryserver.chromium/builders/win/builds/33962
>
>
>> You probably need to add this to xcode_settings below as well (look
>
> for
>>
>> other_cflags in build/common.gypi on how to add raw flags to xcode
>
> configs)
>
> This is not a problem on Mac anyway since 'GCC_TREAT_WARNINGS_AS_ERRORS'
> used below is equivalent to -Wno-error, which supersedes
> -Wno-self-assign
>
> http://codereview.chromium.org/6962035/
>