Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 6962032: Merge 87361 - 2011-05-25 James Simonsen <simonjam@chromium.org> (Closed)

Created:
8 years ago by James Simonsen
Modified:
8 years ago
Reviewers:
James Simonsen
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 87361 - 2011-05-25 James Simonsen <simonjam@chromium.org>; Reviewed by Adam Barth. Add site-specific hack for zipcar.com with old versions of requirejs. https://bugs.webkit.org/show_bug.cgi?id=61321 Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in order. This used to work in webkit by setting a bogus script type (script/cache), then changing the type to a valid one when they wanted to execute it. This hack translates the behavior into the new API (by disabling forceAsync). * html/HTMLScriptElement.cpp: (WebCore::needsOldRequirejsQuirk): Added. (WebCore::HTMLScriptElement::insertedIntoDocument): If hack is needed, set a proper script type so script loads. If script isn't async, disable forceAsync so script executes in order. TBR=simonjam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M Source/WebCore/html/HTMLScriptElement.cpp View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
James Simonsen
8 years ago (2011-05-27 00:26:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698