Avoid trigger compositing update on media player finalization.

Avoid trigger compositing update on media player finalization.

When finalizing a media element and clearing out its associated
media player, prevent the media player finalizer from indirectly
triggering a composition update on the media element itself.
Unsafe, as it will touch other heap objects, which might have
been finalized by now.

R=haraken
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184769

[sof, 2014-11-01 07:44:00]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2014-11-01 07:44:01]

Please take a look.

Just came across this one with ASAN, 

 
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...

#0 0x2ecb5b7 in renderer third_party/WebKit/Source/core/dom/Node.h:495:61
#1 0x2ecb5b7 in blink::Node::renderBoxModelObject() const
third_party/WebKit/Source/core/dom/Node.cpp:607:0
#2 0x2e7c02e in blink::Element::setNeedsCompositingUpdate()
third_party/WebKit/Source/core/dom/Element.cpp:1643:38
#3 0x322f141 in mediaPlayerSetWebLayer
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3951:9
#4 0x322f141 in non-virtual thunk to
blink::HTMLMediaElement::mediaPlayerSetWebLayer(blink::WebLayer*) ...
#5 0x67784e1 in media::WebMediaPlayerImpl::~WebMediaPlayerImpl()
media/blink/webmediaplayer_impl.cc:202:3
#6 0x6778efd in media::WebMediaPlayerImpl::~WebMediaPlayerImpl()
media/blink/webmediaplayer_impl.cc:201:43
#7 0x2ca26d6 in deletePtr third_party/WebKit/Source/wtf/OwnPtrCommon.h:52:9
#8 0x2ca26d6 in clear third_party/WebKit/Source/wtf/OwnPtr.h:134:0
#9 0x2ca26d6 in ~WebMediaPlayerClientImpl
third_party/WebKit/Source/web/WebMediaPlayerClientImpl.cpp:71:0
#10 0x2ca26d6 in blink::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl()
third_party/WebKit/Source/web/WebMediaPlayerClientImpl.cpp:69:0
#11 0x320610e in deletePtr third_party/WebKit/Source/wtf/OwnPtrCommon.h:52:9
#12 0x320610e in clear third_party/WebKit/Source/wtf/OwnPtr.h:134:0
#13 0x320610e in clearMediaPlayerAndAudioSourceProviderClientWithoutLocking
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3458:0
#14 0x320610e in blink::HTMLMediaElement::~HTMLMediaElement()
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:466:0
#15 0x1d3b262 in finalize third_party/WebKit/Source/platform/heap/Heap.cpp:526:9

[haraken, 2014-11-01 07:52:39]

LGTM

[sof, 2014-11-01 07:58:24]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-11-01 07:59:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696103003/1

[commit-bot: I haz the power, 2014-11-01 09:37:31]

Committed patchset #1 (id:1) as 184769