Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: extensions/shell/browser/shell_desktop_controller_aura.h

Issue 696063008: Refactor ShellDesktopController and ShellNativeAppWindow to allow for non-aura implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: + Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/browser/shell_desktop_controller_aura.h
diff --git a/extensions/shell/browser/shell_desktop_controller.h b/extensions/shell/browser/shell_desktop_controller_aura.h
similarity index 76%
rename from extensions/shell/browser/shell_desktop_controller.h
rename to extensions/shell/browser/shell_desktop_controller_aura.h
index 2087234ac820053926e83c86d0bc975c898d4e22..5ec11c9d98088706ad13aecd0070bf07059d79df 100644
--- a/extensions/shell/browser/shell_desktop_controller.h
+++ b/extensions/shell/browser/shell_desktop_controller_aura.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef EXTENSIONS_SHELL_BROWSER_SHELL_DESKTOP_CONTROLLER_H_
-#define EXTENSIONS_SHELL_BROWSER_SHELL_DESKTOP_CONTROLLER_H_
+#ifndef EXTENSIONS_SHELL_BROWSER_SHELL_DESKTOP_CONTROLLER_AURA_H_
+#define EXTENSIONS_SHELL_BROWSER_SHELL_DESKTOP_CONTROLLER_AURA_H_
#include <vector>
@@ -55,22 +55,23 @@ class AppWindowClient;
class Extension;
// Handles desktop-related tasks for app_shell.
-class ShellDesktopController : public DesktopController,
- public aura::client::WindowTreeClient,
+class ShellDesktopControllerAura
+ : public DesktopController,
+ public aura::client::WindowTreeClient,
#if defined(OS_CHROMEOS)
- public chromeos::PowerManagerClient::Observer,
- public ui::DisplayConfigurator::Observer,
+ public chromeos::PowerManagerClient::Observer,
+ public ui::DisplayConfigurator::Observer,
#endif
- public aura::WindowTreeHostObserver {
+ public aura::WindowTreeHostObserver {
public:
- ShellDesktopController();
- ~ShellDesktopController() override;
+ ShellDesktopControllerAura();
+ ~ShellDesktopControllerAura() override;
// DesktopController:
- aura::WindowTreeHost* GetHost() override;
+ gfx::Size GetWindowSize() override;
AppWindow* CreateAppWindow(content::BrowserContext* context,
const Extension* extension) override;
- void AddAppWindow(aura::Window* window) override;
+ void AddAppWindow(gfx::NativeWindow window) override;
void RemoveAppWindow(AppWindow* window) override;
void CloseAppWindows() override;
@@ -81,13 +82,13 @@ class ShellDesktopController : public DesktopController,
#if defined(OS_CHROMEOS)
// chromeos::PowerManagerClient::Observer overrides:
- virtual void PowerButtonEventReceived(bool down,
- const base::TimeTicks& timestamp)
- override;
+ void PowerButtonEventReceived(bool down,
+ const base::TimeTicks& timestamp) override;
// ui::DisplayConfigurator::Observer overrides.
- virtual void OnDisplayModeChanged(const std::vector<
- ui::DisplayConfigurator::DisplayState>& displays) override;
+ void OnDisplayModeChanged(
+ const std::vector<ui::DisplayConfigurator::DisplayState>& displays)
+ override;
#endif
// aura::WindowTreeHostObserver overrides:
@@ -137,9 +138,9 @@ class ShellDesktopController : public DesktopController,
// NativeAppWindow::Close() deletes the AppWindow.
std::vector<AppWindow*> app_windows_;
- DISALLOW_COPY_AND_ASSIGN(ShellDesktopController);
+ DISALLOW_COPY_AND_ASSIGN(ShellDesktopControllerAura);
};
} // namespace extensions
-#endif // EXTENSIONS_SHELL_BROWSER_SHELL_DESKTOP_CONTROLLER_H_
+#endif // EXTENSIONS_SHELL_BROWSER_SHELL_DESKTOP_CONTROLLER_AURA_H_
« no previous file with comments | « extensions/shell/browser/shell_desktop_controller.cc ('k') | extensions/shell/browser/shell_desktop_controller_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698