Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2953)

Unified Diff: extensions/shell/browser/shell_app_window_client_aura.cc

Issue 696063008: Refactor ShellDesktopController and ShellNativeAppWindow to allow for non-aura implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: + Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/browser/shell_app_window_client_aura.cc
diff --git a/extensions/shell/browser/shell_app_window_client.cc b/extensions/shell/browser/shell_app_window_client_aura.cc
similarity index 51%
copy from extensions/shell/browser/shell_app_window_client.cc
copy to extensions/shell/browser/shell_app_window_client_aura.cc
index 293f58b91c7dc427f5c2bc6f0638ef2a2daafaad..af63f278b059e95d1eae16049afa7e1f2052596f 100644
--- a/extensions/shell/browser/shell_app_window_client.cc
+++ b/extensions/shell/browser/shell_app_window_client_aura.cc
@@ -4,44 +4,20 @@
#include "extensions/shell/browser/shell_app_window_client.h"
-#include <vector>
-
#include "extensions/browser/app_window/app_window.h"
#include "extensions/shell/browser/desktop_controller.h"
-#include "extensions/shell/browser/shell_native_app_window.h"
+#include "extensions/shell/browser/shell_native_app_window_aura.h"
namespace extensions {
-ShellAppWindowClient::ShellAppWindowClient() {
-}
-
-ShellAppWindowClient::~ShellAppWindowClient() {
-}
-
-AppWindow* ShellAppWindowClient::CreateAppWindow(
- content::BrowserContext* context,
- const Extension* extension) {
- return DesktopController::instance()->CreateAppWindow(context, extension);
-}
-
NativeAppWindow* ShellAppWindowClient::CreateNativeAppWindow(
AppWindow* window,
AppWindow::CreateParams* params) {
ShellNativeAppWindow* native_app_window =
- new ShellNativeAppWindow(window, *params);
+ new ShellNativeAppWindowAura(window, *params);
DesktopController::instance()->AddAppWindow(
native_app_window->GetNativeWindow());
return native_app_window;
}
-void ShellAppWindowClient::OpenDevToolsWindow(
- content::WebContents* web_contents,
- const base::Closure& callback) {
- NOTIMPLEMENTED();
-}
-
-bool ShellAppWindowClient::IsCurrentChannelOlderThanDev() {
- return false;
-}
-
} // namespace extensions
« no previous file with comments | « extensions/shell/browser/shell_app_window_client.cc ('k') | extensions/shell/browser/shell_browser_main_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698