Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: extensions/shell/browser/default_shell_browser_main_delegate.cc

Issue 696063008: Refactor ShellDesktopController and ShellNativeAppWindow to allow for non-aura implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/default_shell_browser_main_delegate.h" 5 #include "extensions/shell/browser/default_shell_browser_main_delegate.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/strings/string_tokenizer.h" 10 #include "base/strings/string_tokenizer.h"
11 #include "extensions/shell/browser/shell_desktop_controller.h"
12 #include "extensions/shell/browser/shell_extension_system.h" 11 #include "extensions/shell/browser/shell_extension_system.h"
13 #include "extensions/shell/common/switches.h" 12 #include "extensions/shell/common/switches.h"
14 13
14 #if defined(USE_AURA)
15 #include "extensions/shell/browser/shell_desktop_controller_aura.h"
16 #endif
17
15 namespace extensions { 18 namespace extensions {
16 19
17 DefaultShellBrowserMainDelegate::DefaultShellBrowserMainDelegate() { 20 DefaultShellBrowserMainDelegate::DefaultShellBrowserMainDelegate() {
18 } 21 }
19 22
20 DefaultShellBrowserMainDelegate::~DefaultShellBrowserMainDelegate() { 23 DefaultShellBrowserMainDelegate::~DefaultShellBrowserMainDelegate() {
21 } 24 }
22 25
23 void DefaultShellBrowserMainDelegate::Start( 26 void DefaultShellBrowserMainDelegate::Start(
24 content::BrowserContext* browser_context) { 27 content::BrowserContext* browser_context) {
(...skipping 21 matching lines...) Expand all
46 } else { 49 } else {
47 LOG(ERROR) << "--" << switches::kAppShellAppPath 50 LOG(ERROR) << "--" << switches::kAppShellAppPath
48 << " unset; boredom is in your future"; 51 << " unset; boredom is in your future";
49 } 52 }
50 } 53 }
51 54
52 void DefaultShellBrowserMainDelegate::Shutdown() { 55 void DefaultShellBrowserMainDelegate::Shutdown() {
53 } 56 }
54 57
55 DesktopController* DefaultShellBrowserMainDelegate::CreateDesktopController() { 58 DesktopController* DefaultShellBrowserMainDelegate::CreateDesktopController() {
56 return new ShellDesktopController(); 59 #if defined(USE_AURA)
Yoyo Zhou 2014/11/11 01:55:31 These look a little funny now, but they'll make se
James Cook 2014/11/11 18:23:52 Acknowledged.
60 return new ShellDesktopControllerAura();
61 #else
62 return NULL;
63 #endif
57 } 64 }
58 65
59 } // namespace extensions 66 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698