Issue 696063006: Reenable deprecation warnings on Android framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 696063006: Reenable deprecation warnings on Android framework. (Closed)

Created:
6 years, 1 month ago by scroggo

Modified:
6 years, 1 month ago

Reviewers:
djsollen, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Reenable deprecation warnings on Android framework. Most recently introduced here: https://codereview.chromium.org/304333002 It appears these are not currently needed (I just disabled it and successfully built). Since we appear to be out of the transitional period, I propose we remove them so we can know if we deprecate something Android uses (and fix the call site). Committed: https://skia.googlesource.com/skia/+/a99f9eeed6d71e6c529f5a6c0a99b3efedeb3053

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696063006/1

6 years, 1 month ago (2014-11-11 14:55:25 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-11 15:04:42 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a99f9eeed6d71e6c529f5a6c0a99b3efedeb3053