Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: media/cast/rtcp/rtcp_receiver.cc

Issue 69603002: Incorporating logging into Cast (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing errors Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/rtcp/rtcp_receiver.cc
diff --git a/media/cast/rtcp/rtcp_receiver.cc b/media/cast/rtcp/rtcp_receiver.cc
index 5bdaadd3da5a77687b58db434343f7bbdd5249cf..a6a40a16ec923343d205dc8e4b93e33b1078c33a 100644
--- a/media/cast/rtcp/rtcp_receiver.cc
+++ b/media/cast/rtcp/rtcp_receiver.cc
@@ -4,14 +4,14 @@
#include "media/cast/rtcp/rtcp_receiver.h"
-#include "base/debug/trace_event.h"
#include "base/logging.h"
#include "media/cast/rtcp/rtcp_utility.h"
namespace media {
namespace cast {
-RtcpReceiver::RtcpReceiver(RtcpSenderFeedback* sender_feedback,
+RtcpReceiver::RtcpReceiver(scoped_refptr<CastEnvironment> cast_environment,
+ RtcpSenderFeedback* sender_feedback,
RtcpReceiverFeedback* receiver_feedback,
RtcpRttFeedback* rtt_feedback,
uint32 local_ssrc)
@@ -19,8 +19,8 @@ RtcpReceiver::RtcpReceiver(RtcpSenderFeedback* sender_feedback,
remote_ssrc_(0),
sender_feedback_(sender_feedback),
receiver_feedback_(receiver_feedback),
- rtt_feedback_(rtt_feedback) {
-}
+ rtt_feedback_(rtt_feedback),
+ cast_environment_(cast_environment) {}
RtcpReceiver::~RtcpReceiver() {}
@@ -162,13 +162,10 @@ void RtcpReceiver::HandleReportBlock(const RtcpField* rtcp_field,
return;
}
VLOG(1) << "Cast RTCP received RB from SSRC " << remote_ssrc;
-
- TRACE_COUNTER_ID1("cast_rtcp", "RtcpReceiver::FractionLost",
- rb.ssrc, rb.fraction_lost);
- TRACE_COUNTER_ID1("cast_rtcp", "RtcpReceiver::CumulativeNumberOfPacketsLost",
- rb.ssrc, rb.cumulative_number_of_packets_lost);
- TRACE_COUNTER_ID1("cast_rtcp", "RtcpReceiver::Jitter",
- rb.ssrc, rb.jitter);
+ cast_environment_->Logging()->InsertGenericEvent(kPacketLoss,
+ rb.fraction_lost);
+ cast_environment_->Logging()->InsertGenericEvent(kJitterMs,
+ rb.jitter);
RtcpReportBlock report_block;
report_block.remote_ssrc = remote_ssrc;

Powered by Google App Engine
This is Rietveld 408576698