Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: media/cast/logging/logging_defines.h

Issue 69603002: Incorporating logging into Cast (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding scoped_ptr include Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/logging/logging.gyp ('k') | media/cast/logging/logging_defines.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/logging_defines.h
diff --git a/media/cast/logging/logging_defines.h b/media/cast/logging/logging_defines.h
index 6388a12629b45bd44e0647268444f2fe2c193439..1a64e23d2f72aba14b5db0c21225a34d4c73e2dc 100644
--- a/media/cast/logging/logging_defines.h
+++ b/media/cast/logging/logging_defines.h
@@ -15,15 +15,29 @@
namespace media {
namespace cast {
+struct CastLoggingConfig {
+ CastLoggingConfig();
+ ~CastLoggingConfig();
+
+ bool enable_data_collection;
+ bool enable_uma_stats;
+ bool enable_tracing;
+};
+
+// By default, enable raw and stats data collection. Disable tracing and UMA.
+CastLoggingConfig GetDefaultCastLoggingConfig();
+
enum CastLoggingEvent {
// Generic events.
- kRtt,
+ kRttMs,
kPacketLoss,
- kJitter,
+ kJitterMs,
kAckReceived,
+ kRembBitrate,
kAckSent,
kLastEvent,
// Audio sender.
+ kAudioFrameReceived,
kAudioFrameCaptured,
kAudioFrameEncoded,
// Audio receiver.
@@ -31,6 +45,7 @@ enum CastLoggingEvent {
kAudioFrameDecoded,
// Video sender.
kVideoFrameCaptured,
+ kVideoFrameReceived,
kVideoFrameSentToEncoder,
kVideoFrameEncoded,
// Video receiver.
@@ -42,6 +57,8 @@ enum CastLoggingEvent {
kPacketRetransmited,
// Receive-side packet events.
kPacketReceived,
+
+ kNumOfLoggingEvents,
};
std::string CastLoggingToString(CastLoggingEvent event);
@@ -51,7 +68,7 @@ struct FrameEvent {
~FrameEvent();
uint32 frame_id;
- int size; // Encoded size only.
+ size_t size; // Encoded size only.
std::vector<base::TimeTicks> timestamp;
std::vector<CastLoggingEvent> type;
base::TimeDelta delay_delta; // Render/playout delay.
@@ -62,7 +79,7 @@ struct BasePacketInfo {
BasePacketInfo();
~BasePacketInfo();
- int size;
+ size_t size;
std::vector<base::TimeTicks> timestamp;
std::vector<CastLoggingEvent> type;
};
« no previous file with comments | « media/cast/logging/logging.gyp ('k') | media/cast/logging/logging_defines.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698