media/cast/video_receiver/codecs/vp8/vp8_decoder.cc - Issue 69603002: Incorporating logging into Cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/video_receiver/codecs/vp8/vp8_decoder.cc

Issue 69603002: Incorporating logging into Cast (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clean up Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/video_receiver/codecs/vp8/vp8_decoder.cc

diff --git a/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc b/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc

index 8ca6acfc15b1d5aa7405c140482eeea691801ef4..b5a123e982ef75d4177fa0bc3043b1bdf9dce697 100644

--- a/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc

+++ b/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc

@@ -83,6 +83,8 @@ bool Vp8Decoder::Decode(const EncodedVideoFrame* encoded_frame,

memcpy(decoded_frame->v_plane.data, img->planes[VPX_PLANE_V],

decoded_frame->v_plane.length);

+ cast_environment_->Logging()->InsertFrameEvent(kVideoFrameDecoded,

+ -1, encoded_frame->frame_id);

Alpha Left Google 2013/11/14 00:29:24 Add a TODO here to replace -1 with something meani

mikhal 2013/11/14 17:42:31 Done.

// Return frame.

VLOG(1) << "Decoded frame " << frame_id_int;

// Frame decoded - return frame to the user via callback.