Incorporating logging into Cast

media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.h"
 
 #include "base/logging.h"
 #include "media/cast/cast_defines.h"
 #include "media/cast/pacing/paced_sender.h"
 #include "net/base/big_endian.h"
@@ skipping 21 matching lines @@
 }
 
 RtpPacketizer::~RtpPacketizer() {}
 
 void RtpPacketizer::IncomingEncodedVideoFrame(
     const EncodedVideoFrame* video_frame,
     const base::TimeTicks& capture_time) {
   DCHECK(!config_.audio) << "Invalid state";
   if (config_.audio) return;
 
-  base::TimeTicks zero_time;
-  base::TimeDelta capture_delta = capture_time - zero_time;
-
   // Timestamp is in 90 KHz for video.
-  rtp_timestamp_ = static_cast<uint32>(capture_delta.InMilliseconds() * 90);
+  rtp_timestamp_ = GetVideoRtpTimestamp(capture_time);
   time_last_sent_rtp_timestamp_ = capture_time;
 
   Cast(video_frame->key_frame,
        video_frame->frame_id,
        video_frame->last_referenced_frame_id,
        rtp_timestamp_,
        video_frame->data);
 }
 
 void RtpPacketizer::IncomingEncodedAudioFrame(
@@ skipping 18 matching lines @@
 
   *time_sent = time_last_sent_rtp_timestamp_;
   *rtp_timestamp = rtp_timestamp_;
   return true;
 }
 
 void RtpPacketizer::Cast(bool is_key,
                          uint8 frame_id,
                          uint8 reference_frame_id,
                          uint32 timestamp,
                          std::vector<uint8> data) {

[Alpha Left Google, 2013/11/14 19:54:57]

I just noticed that this code does a copy of |data|. And all it does internally
is use it with an iterator. This should be fixed to just take a const ref.
Please add a TODO.

   uint16 rtp_header_length = kCommonRtpHeaderLength + kCastRtpHeaderLength;
   uint16 max_length = config_.max_payload_length - rtp_header_length - 1;
 
   // Split the payload evenly (round number up).
   size_t num_packets = (data.size() + max_length) / max_length;
   size_t payload_length = (data.size() + num_packets) / num_packets;
   DCHECK_LE(payload_length, max_length) << "Invalid argument";
 
   PacketList packets;
 
@@ skipping 50 matching lines @@
   packet->resize(start_size + 10);
   net::BigEndianWriter big_endian_writer(&((*packet)[start_size]), 10);
   big_endian_writer.WriteU16(sequence_number_);
   big_endian_writer.WriteU32(time_stamp);
   big_endian_writer.WriteU32(config_.ssrc);
   ++sequence_number_;
 }
 
 }  // namespace cast
 }  // namespace media