Incorporating logging into Cast

media/cast/video_sender/video_encoder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/video_sender/video_encoder.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 
 namespace media {
@@ skipping 47 matching lines @@
     const CodecDynamicConfig& dynamic_config,
     const FrameEncodedCallback& frame_encoded_callback,
     const base::Closure frame_release_callback) {
   if (dynamic_config.key_frame_requested) {
     vp8_encoder_->GenerateKeyFrame();
   }
   vp8_encoder_->LatestFrameIdToReference(
       dynamic_config.latest_frame_id_to_reference);
   vp8_encoder_->UpdateRates(dynamic_config.bit_rate);
 
+
+  uint32 rtp_timestamp = GetVideoRtpTimestamp(capture_time);
+  cast_environment_->Logging()->InsertFrameEvent(kVideoFrameSentToEncoder,
+      -1, rtp_timestamp);

[Alpha Left Google, 2013/11/14 00:29:24]

Add a TODO here to replace -1 with something meaningful.

[mikhal, 2013/11/14 17:42:31]

Replaced with const, as in other locations.
On 2013/11/14 00:29:24, Alpha wrote:

   scoped_ptr<EncodedVideoFrame> encoded_frame(new EncodedVideoFrame());
   bool retval = vp8_encoder_->Encode(*video_frame, encoded_frame.get());
 
   // We are done with the video frame release it.
   cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
                               frame_release_callback);
 
   if (!retval) {
     VLOG(1) << "Encoding failed";
     return;
   }
   if (encoded_frame->data.size() <= 0) {
     VLOG(1) << "Encoding resulted in an empty frame";
     return;
   }
+  cast_environment_->Logging()->InsertFrameEvent(kVideoFrameEncoded,
+      rtp_timestamp, -1);

[Alpha Left Google, 2013/11/14 00:29:24]

Add a TODO here to replace -1 with something meaningful.

[mikhal, 2013/11/14 17:42:31]

see above
On 2013/11/14 00:29:24, Alpha wrote:

   cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
       base::Bind(frame_encoded_callback,
           base::Passed(&encoded_frame), capture_time));
 }
 
 // Inform the encoder about the new target bit rate.
 void VideoEncoder::SetBitRate(int new_bit_rate) {
   dynamic_config_.bit_rate = new_bit_rate;
 }
 
@@ skipping 11 matching lines @@
 void VideoEncoder::LatestFrameIdToReference(uint8 frame_id) {
   dynamic_config_.latest_frame_id_to_reference = frame_id;
 }
 
 int VideoEncoder::NumberOfSkippedFrames() const {
   return skip_count_;
 }
 
 }  //  namespace cast
 }  //  namespace media