download_from_google_storage.py - Issue 696023002: Delete before cp in download_from_google_storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: download_from_google_storage.py

Issue 696023002: Delete before cp in download_from_google_storage (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: download_from_google_storage.py

diff --git a/download_from_google_storage.py b/download_from_google_storage.py

index 8370515e6a15879c3ddf5c1e8693efeb595a8ccd..cd284597f380841ace00c678562d0c5316c7e6f1 100755

--- a/download_from_google_storage.py

+++ b/download_from_google_storage.py

@@ -236,8 +236,11 @@ def _downloader_worker_thread(thread_num, q, force, base_url,

file_url, output_filename)))

continue

# Fetch the file.

- out_q.put('%d> Downloading %s...' % (

- thread_num, output_filename))

+ out_q.put('%d> Downloading %s...' % (thread_num, output_filename))

+ try:

+ os.remove(output_filename) # Delete the file if it exists already.

+ except OSError:

+ pass

pgervais 2014/10/31 22:25:08 Please print an error message if the file still ex

hinoka 2014/10/31 22:37:00 Done.

code, _, err = gsutil.check_call('cp', '-q', file_url, output_filename)

if code != 0:

out_q.put('%d> %s' % (thread_num, err))

« no previous file with comments | « no previous file | no next file » | no next file with comments »