Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 696023002: Delete before cp in download_from_google_storage (Closed)

Created:
6 years, 1 month ago by hinoka
Modified:
6 years, 1 month ago
Reviewers:
agable, pgervais
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Delete before cp in download_from_google_storage BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292819

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M download_from_google_storage.py View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
hinoka
6 years, 1 month ago (2014-10-31 21:58:49 UTC) #2
pgervais
https://codereview.chromium.org/696023002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/696023002/diff/1/download_from_google_storage.py#newcode243 download_from_google_storage.py:243: pass Please print an error message if the file ...
6 years, 1 month ago (2014-10-31 22:25:08 UTC) #3
hinoka
https://codereview.chromium.org/696023002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/696023002/diff/1/download_from_google_storage.py#newcode243 download_from_google_storage.py:243: pass On 2014/10/31 22:25:08, pgervais wrote: > Please print ...
6 years, 1 month ago (2014-10-31 22:37:01 UTC) #4
pgervais
On 2014/10/31 22:37:01, hinoka wrote: > https://codereview.chromium.org/696023002/diff/1/download_from_google_storage.py > File download_from_google_storage.py (right): > > https://codereview.chromium.org/696023002/diff/1/download_from_google_storage.py#newcode243 > ...
6 years, 1 month ago (2014-10-31 22:42:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696023002/20001
6 years, 1 month ago (2014-10-31 22:45:20 UTC) #7
commit-bot: I haz the power
Presubmit check for 696023002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 1 month ago (2014-10-31 22:47:10 UTC) #9
agable
lgtm
6 years, 1 month ago (2014-11-04 00:38:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696023002/20001
6 years, 1 month ago (2014-11-04 00:39:07 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:40:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 292819

Powered by Google App Engine
This is Rietveld 408576698