Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 696013002: Fix closure compile. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
mukesh agrawal
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-compile
Project:
chromium
Visibility:
Public.

Description

Fix closure compile. ## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:445: ERROR - Property wifiCredentialsSynced never defined on args ## $('wifi-credentials-checkbox').checked = args.wifiCredentialsSynced; ## ^ ## ## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:447: ERROR - Property wifiCredentialsSynced never defined on args ## args.wifiCredentialsSynced; ## ^ ## ## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:449: ERROR - Property wifiCredentialsEnforced never defined on args ## args.wifiCredentialsEnforced; ## ^ BUG=none TEST=green closure bot TBR=quiche@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/607650334c3ad6c1c177967b35017d6334f54512 Cr-Commit-Position: refs/heads/master@{#302329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/sync_setup_overlay.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Dan Beam
6 years, 1 month ago (2014-10-31 21:42:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696013002/1
6 years, 1 month ago (2014-10-31 21:44:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 21:45:30 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/607650334c3ad6c1c177967b35017d6334f54512 Cr-Commit-Position: refs/heads/master@{#302329}
6 years, 1 month ago (2014-10-31 21:46:02 UTC) #5
mukesh agrawal
On 2014/10/31 21:46:02, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 1 month ago (2014-10-31 21:57:11 UTC) #6
mukesh agrawal
lgtm
6 years, 1 month ago (2014-10-31 21:57:31 UTC) #7
Dan Beam
6 years, 1 month ago (2014-10-31 22:06:03 UTC) #8
Message was sent while issue was closed.
On 2014/10/31 21:57:11, mukesh agrawal wrote:
> On 2014/10/31 21:46:02, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/607650334c3ad6c1c177967b35017d6334f54512
> > Cr-Commit-Position: refs/heads/master@{#302329}
> 
> lgtm, and thanks for fixing.
> 
> (what's the recommended way to avoid breaking things next time? should i
> manually trigger a closure bot run if my CL has JS changes?)

eh, we're working on try bots for this.  that'd be the easiest.

in the mean time, locally doing:

  gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C
out/Default

will probably work (may require a `sudo apt-get install gyp`).

it's not really that problematic to just fix after it breaks, swear ;)

Powered by Google App Engine
This is Rietveld 408576698