src/assembler_ia32.cpp - Issue 695993004: Subzero: Switch to AT&T asm syntax. I give up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler_ia32.cpp

Issue 695993004: Subzero: Switch to AT&T asm syntax. I give up. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add opcode suffix to xchg. Use .L$ prefix for constant pool entries. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler_ia32.cpp

diff --git a/src/assembler_ia32.cpp b/src/assembler_ia32.cpp

index 11ff859b739f72b732384717204d331bae62315a..8857a57cdce6b9040dc57d6b98d7a8452dbae398 100644

--- a/src/assembler_ia32.cpp

+++ b/src/assembler_ia32.cpp

@@ -57,7 +57,7 @@ Address Address::ofConstPool(GlobalContext *Ctx, Assembler *Asm,

llvm::raw_string_ostream StrBuf(Buffer);

Type Ty = Imm->getType();

assert(llvm::isa<ConstantFloat>(Imm) || llvm::isa<ConstantDouble>(Imm));

- StrBuf << "L$" << Ty << "$" << Imm->getPoolEntryID();

+ StrBuf << ".L$" << Ty << "$" << Imm->getPoolEntryID();

const RelocOffsetT Offset = 0;

const bool SuppressMangling = true;

Constant *Sym =

« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | tests_lit/assembler/x86/immediate_encodings.ll » ('j') | no next file with comments »