[Password Autofill] Disable one click popup on Android.

components/autofill/content/renderer/autofill_agent.cc

Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 0a9b57fd13bf442ea9e3720934c9adf3248a8dc1..6b52183554f2469cc036173891fa73955c80b080 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -318,13 +318,21 @@ void AutofillAgent::FormControlElementClicked(
 
   bool show_full_suggestion_list = element.isAutofilled() || was_focused;
   bool show_password_suggestions_only = !was_focused;
-  ShowSuggestions(element,
-                  true,
-                  false,
-                  true,
-                  false,
-                  show_full_suggestion_list,
-                  show_password_suggestions_only);
+
+  // TODO(gcasto): Remove after crbug.com/423464 has been fixed.
+  bool show_suggestions = true;
+#if defined(OS_ANDROID)
+  show_suggestions = was_focused;
+#endif
+
+  if (show_suggestions)

[please use gerrit instead, 2014/11/03 23:23:12]

nit: please use curly braces for the body of the if statement, because the body
is multi-line.

[Garrett Casto, 2014/11/03 23:59:02]

Done.

+    ShowSuggestions(element,
+                    true,
+                    false,
+                    true,
+                    false,
+                    show_full_suggestion_list,
+                    show_password_suggestions_only);
 }
 
 void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) {