Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 695953002: Update html_viewer to follow to content handle API change. (Closed)

Created:
6 years, 1 month ago by qsr
Modified:
6 years, 1 month ago
Reviewers:
Aaron Boodman, jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update html_viewer to follow to content handle API change. R=aa@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -29 lines) Patch
M mojo/services/html_viewer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 4 chunks +13 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 4 chunks +16 lines, -10 lines 1 comment Download
M mojo/services/html_viewer/html_viewer.cc View 3 chunks +5 lines, -15 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
qsr
6 years, 1 month ago (2014-10-31 17:57:37 UTC) #1
qsr
This CL will be needed for the next roll of mojo to chromium.
6 years, 1 month ago (2014-10-31 17:58:48 UTC) #3
jamesr
Ah thanks, I'm already mostly through this (I'm doing an SDK roll) but will cross-check.
6 years, 1 month ago (2014-10-31 18:07:12 UTC) #4
jamesr
Thanks, I'll land this with the rest of the roll. Very useful. https://codereview.chromium.org/695953002/diff/1/mojo/services/html_viewer/html_document_view.cc File mojo/services/html_viewer/html_document_view.cc ...
6 years, 1 month ago (2014-10-31 18:10:19 UTC) #5
jamesr
6 years, 1 month ago (2014-10-31 18:29:31 UTC) #6
Incorporated this patch into https://codereview.chromium.org/694923002/

Powered by Google App Engine
This is Rietveld 408576698