Reland "Prepare blink to unify definitions of load completion"

Reland "Prepare blink to unify definitions of load completion"

Currently, FrameLoader.cpp contains a function called isDocumentDoneLoading,
which has a complicated set of rules to determine when to tell chromium that
loading is complete. These rules only really exist for the sake of layout
tests, which can't always just define load event completion as the end of
the test. A set of rules have been added to the layout tests harness behind
a build flag, so add a flagged version of load completion in blink that is
strongly mapped to load event completion.

Lots of tests need subtle changes. Most of these are forced layouts, waiting for RAF to complete, simple waitUntilDone/notifyDone pairs, and adding missing document.close() calls.

BUG=426520
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184937

[Nate Chapin, 2014-10-31 17:49:38]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2014-10-31 17:49:40]

Take 3!

The only changes from my previous attempt
(http://src.chromium.org/viewvc/blink?view=revision&revision=184609) are to
de-flake a layout test.

See LayoutTests/fast/parser/adoption-agency-crash-01.html and
LayoutTests/fast/parser/adoption-agency-crash-01-expected.txt for those new
changes.

[dcheng, 2014-10-31 17:52:15]

lgtm

[Nate Chapin, 2014-10-31 17:52:34]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-10-31 17:53:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695943002/1

[commit-bot: I haz the power, 2014-10-31 19:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 19:23:17]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[Nate Chapin, 2014-11-03 18:25:20]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-11-03 18:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695943002/1

[commit-bot: I haz the power, 2014-11-03 18:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 18:26:49]

Failed to apply patch for Source/core/dom/Document.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.h
  Hunk #1 FAILED at 904.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/Document.h.rej

Patch:       Source/core/dom/Document.h
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index
d81b9461be2d20b4129244bb55212e5eb586aa5c..060a5f347682239f89d3760d4b2089e5e695285b
100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -904,6 +904,7 @@ public:
     bool processingLoadEvent() const { return m_loadEventProgress ==
LoadEventInProgress; }
     bool loadEventFinished() const { return m_loadEventProgress >=
LoadEventCompleted; }
     bool unloadStarted() const { return m_loadEventProgress >=
PageHideInProgress; }
+    void suppressLoadEvent() { m_loadEventProgress = LoadEventCompleted; }
 
     void setContainsPlugins() { m_containsPlugins = true; }
     bool containsPlugins() const { return m_containsPlugins; }

[Nate Chapin, 2014-11-06 21:56:54]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-11-06 21:57:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695943002/60001

[Nate Chapin, 2014-11-06 21:59:58]

The CQ bit was unchecked by japhet@chromium.org

[Nate Chapin, 2014-11-06 22:20:21]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-11-06 22:20:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695943002/80001

[commit-bot: I haz the power, 2014-11-06 23:32:30]

Committed patchset #5 (id:80001) as 184937