Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 695933002: MIPS64: Fix simulator arguments handling on generated code entry. (Closed)

Created:
6 years, 1 month ago by dusmil.imgtec
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix simulator arguments handling on generated code entry. Removed workaround for this issue. TEST=mjsunit, cctest on sim64 BUG= R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=25043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dusmil.imgtec
6 years, 1 month ago (2014-10-31 17:24:31 UTC) #2
paul.l...
LGTM, but can you update the commit message with at least one specific failing test ...
6 years, 1 month ago (2014-10-31 17:28:27 UTC) #3
dusmil.imgtec
Fixing out GH issue #92.
6 years, 1 month ago (2014-10-31 18:07:42 UTC) #4
dusmil.imgtec
On 2014/10/31 18:07:42, dusmil.imgtec wrote: > Fixing out GH issue #92. Sorry, typo. Fixing our ...
6 years, 1 month ago (2014-10-31 18:08:44 UTC) #5
paul.l...
Got it. This is fine to land as is. Once we move to the new ...
6 years, 1 month ago (2014-10-31 18:32:21 UTC) #6
dusmil.imgtec
6 years, 1 month ago (2014-10-31 18:33:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25043 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698