Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 695913003: Add more allocator.gyp:allocator dependencies (Closed)

Created:
6 years, 1 month ago by hans
Modified:
6 years, 1 month ago
Reviewers:
Nico, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more allocator.gyp:allocator dependencies The dependency is necessary to avoid multiple definitions of memory allocation functions in static_library Debug builds on Windows. BUG=429498 NOTRY=true Committed: https://crrev.com/eec0e16fd896b4670bddf2ff5d1c70d5f5cbb173 Cr-Commit-Position: refs/heads/master@{#302663}

Patch Set 1 #

Patch Set 2 : Fix two more; now i can build 'all' in 32-bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M ash/ash.gyp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +10 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +17 lines, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/examples/examples.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
hans
This fixes all the targets I could build before running out of disk space on ...
6 years, 1 month ago (2014-11-04 13:22:38 UTC) #2
sky
Can't this be injected at a lower level so each executable doesn't need it?
6 years, 1 month ago (2014-11-04 14:11:36 UTC) #3
hans
On 2014/11/04 14:11:36, sky wrote: > Can't this be injected at a lower level so ...
6 years, 1 month ago (2014-11-04 14:45:12 UTC) #4
Nico
lgtm, thanks! I guess you did a static debug build locally and added everything that ...
6 years, 1 month ago (2014-11-04 15:54:08 UTC) #5
hans
On 2014/11/04 15:54:08, Nico wrote: > I guess you did a static debug build locally ...
6 years, 1 month ago (2014-11-04 16:05:55 UTC) #6
hans
sky: can i have OWNERS stamp?
6 years, 1 month ago (2014-11-04 16:23:12 UTC) #7
sky
Ok, LGTM
6 years, 1 month ago (2014-11-04 18:12:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695913003/20001
6 years, 1 month ago (2014-11-04 18:33:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8411)
6 years, 1 month ago (2014-11-04 19:57:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695913003/20001
6 years, 1 month ago (2014-11-04 20:49:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 21:03:02 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 21:05:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eec0e16fd896b4670bddf2ff5d1c70d5f5cbb173
Cr-Commit-Position: refs/heads/master@{#302663}

Powered by Google App Engine
This is Rietveld 408576698