Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 695883002: Create ListContainer and SpinnerController class. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Create ListContainer and SpinnerController class. BUG=267281 TEST=None Committed: https://crrev.com/f59c958430b774a47374c08c210f643e895dc098 Cr-Commit-Position: refs/heads/master@{#302591}

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Fixed. #

Patch Set 3 : Remove debug log. #

Patch Set 4 : #

Patch Set 5 : Fixed test. #

Patch Set 6 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -145 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 4 5 17 chunks +27 lines, -145 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/spinner_controller.js View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +6 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/ui/list_container.js View 1 2 3 4 5 1 chunk +128 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
hirono
PTAL the CL? Thanks!
6 years, 1 month ago (2014-10-31 14:31:48 UTC) #3
fukino
Thanks! lgtm with nits: https://codereview.chromium.org/695883002/diff/20001/ui/file_manager/file_manager/foreground/js/spinner_controller.js File ui/file_manager/file_manager/foreground/js/spinner_controller.js (right): https://codereview.chromium.org/695883002/diff/20001/ui/file_manager/file_manager/foreground/js/spinner_controller.js#newcode8 ui/file_manager/file_manager/foreground/js/spinner_controller.js:8: * @param {DirectoryModel} directoryModel !DirectoryModel ...
6 years, 1 month ago (2014-10-31 15:14:23 UTC) #4
hirono
Thanks! https://codereview.chromium.org/695883002/diff/20001/ui/file_manager/file_manager/foreground/js/spinner_controller.js File ui/file_manager/file_manager/foreground/js/spinner_controller.js (right): https://codereview.chromium.org/695883002/diff/20001/ui/file_manager/file_manager/foreground/js/spinner_controller.js#newcode8 ui/file_manager/file_manager/foreground/js/spinner_controller.js:8: * @param {DirectoryModel} directoryModel On 2014/10/31 15:14:23, fukino ...
6 years, 1 month ago (2014-10-31 18:07:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695883002/40001
6 years, 1 month ago (2014-10-31 18:08:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695883002/60001
6 years, 1 month ago (2014-10-31 18:13:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695883002/80001
6 years, 1 month ago (2014-10-31 18:21:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/7451)
6 years, 1 month ago (2014-10-31 19:26:34 UTC) #15
hirono
@fukino - I fixed a test. The event was bubbled to the parent in UI ...
6 years, 1 month ago (2014-11-04 00:55:16 UTC) #16
hirono
It looks tests are still broken. Let me fix again.
6 years, 1 month ago (2014-11-04 04:10:14 UTC) #17
hirono
Done. PTAL
6 years, 1 month ago (2014-11-04 05:16:27 UTC) #18
fukino
On 2014/11/04 05:16:27, hirono wrote: > Done. PTAL still lgtm.
6 years, 1 month ago (2014-11-04 06:03:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695883002/120001
6 years, 1 month ago (2014-11-04 06:07:19 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:120001)
6 years, 1 month ago (2014-11-04 08:56:16 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 08:56:50 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f59c958430b774a47374c08c210f643e895dc098
Cr-Commit-Position: refs/heads/master@{#302591}

Powered by Google App Engine
This is Rietveld 408576698