Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 695873003: Linkify some manifest keys + remove .html (Closed)

Created:
6 years, 1 month ago by robwu
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linkify some manifest keys + remove .html NOTRY=true R=kalman@chromium.org Committed: https://crrev.com/bd6b31d3c261ffd2323285fcf90d46143a192556 Cr-Commit-Position: refs/heads/master@{#302386}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase + add "tabs" example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -44 lines) Patch
M chrome/common/extensions/docs/templates/json/manifest.json View 1 3 chunks +60 lines, -44 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
robwu
6 years, 1 month ago (2014-10-31 17:55:16 UTC) #1
not at google - send to devlin
Thanks :) lgtm. https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json File chrome/common/extensions/docs/templates/json/manifest.json (right): https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json#newcode142 chrome/common/extensions/docs/templates/json/manifest.json:142: "example": [] maybe put "tabs" in ...
6 years, 1 month ago (2014-10-31 17:55:56 UTC) #2
robwu
https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json File chrome/common/extensions/docs/templates/json/manifest.json (right): https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json#newcode142 chrome/common/extensions/docs/templates/json/manifest.json:142: "example": [] On 2014/10/31 17:55:56, kalman wrote: > maybe ...
6 years, 1 month ago (2014-10-31 18:02:48 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json File chrome/common/extensions/docs/templates/json/manifest.json (right): https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json#newcode142 chrome/common/extensions/docs/templates/json/manifest.json:142: "example": [] On 2014/10/31 18:02:48, robwu wrote: > On ...
6 years, 1 month ago (2014-10-31 21:41:29 UTC) #4
robwu
https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json File chrome/common/extensions/docs/templates/json/manifest.json (right): https://codereview.chromium.org/695873003/diff/1/chrome/common/extensions/docs/templates/json/manifest.json#newcode142 chrome/common/extensions/docs/templates/json/manifest.json:142: "example": [] On 2014/10/31 21:41:28, kalman wrote: > On ...
6 years, 1 month ago (2014-11-01 00:20:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695873003/20001
6 years, 1 month ago (2014-11-01 15:54:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-01 15:55:11 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 15:55:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd6b31d3c261ffd2323285fcf90d46143a192556
Cr-Commit-Position: refs/heads/master@{#302386}

Powered by Google App Engine
This is Rietveld 408576698