Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 695853002: Include Web Notifications on Android at build-time. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
Reviewers:
dewittj
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Include Web Notifications on Android at build-time. This increases the size of ChromeShell.apk by 16.8 KiB in debug builds and 18.7 KiB in release builds. BUG=90795, 115320 Committed: https://crrev.com/459eb777b9914f375ae246196efbb07ec31ba930 Cr-Commit-Position: refs/heads/master@{#302291}

Patch Set 1 #

Patch Set 2 : attempt 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.h View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
Justin: PTAL. I'll add binary size info in a moment.
6 years, 1 month ago (2014-10-31 13:47:56 UTC) #2
dewittj
lgtm
6 years, 1 month ago (2014-10-31 16:19:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695853002/20001
6 years, 1 month ago (2014-10-31 16:26:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 18:55:13 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 18:56:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/459eb777b9914f375ae246196efbb07ec31ba930
Cr-Commit-Position: refs/heads/master@{#302291}

Powered by Google App Engine
This is Rietveld 408576698