sky/viewer/document_view.cc - Issue 695803003: Make clicks on <a> request a navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/document_view.cc

Issue 695803003: Make clicks on <a> request a navigation (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/viewer/document_view.cc

diff --git a/sky/viewer/document_view.cc b/sky/viewer/document_view.cc

index f1d36df373418e1f7a087f1be14eef53ad1090b5..f7c002ab79b3beb22d847cef6ea6a71e7ccad9b8 100644

--- a/sky/viewer/document_view.cc

+++ b/sky/viewer/document_view.cc

@@ -187,8 +187,8 @@ void DocumentView::didCreateScriptContext(blink::WebLocalFrame* frame,

gin::ConvertToV8(isolate, internals));

}

-blink::ServiceProvider* DocumentView::services() {

- return this;

+blink::ServiceProvider& DocumentView::services() {

+ return *this;

}

mojo::NavigatorHost* DocumentView::NavigatorHost() {