sky/engine/core/testing/DummyPageHolder.cpp - Issue 695803003: Make clicks on <a> request a navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/testing/DummyPageHolder.cpp

Issue 695803003: Make clicks on <a> request a navigation (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/testing/DummyPageHolder.cpp

diff --git a/sky/engine/core/testing/DummyPageHolder.cpp b/sky/engine/core/testing/DummyPageHolder.cpp

index a1f6c181103f4865805f8430a7480291f268ff40..e3b998f7ca4ecbedd7b7d23f3d3a7fd7e7c59c3b 100644

--- a/sky/engine/core/testing/DummyPageHolder.cpp

+++ b/sky/engine/core/testing/DummyPageHolder.cpp

@@ -59,7 +59,7 @@ DummyPageHolder::DummyPageHolder(

m_pageClients.editorClient = pageClients->editorClient;

m_pageClients.spellCheckerClient = pageClients->spellCheckerClient;

}

- m_page = adoptPtr(new Page(m_pageClients, 0));

+ // m_page = adoptPtr(new Page(m_pageClients, 0));

eseidel 2014/10/31 18:16:54 ??

// FIXME(sky): Delete the tests that use DummyPageHolder since

// they no longer work and we're not running them.

« no previous file with comments | « sky/engine/core/page/Page.cpp ('k') | sky/engine/public/web/WebViewClient.h » ('j') | no next file with comments »