Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 695773004: Fix getters for the printing preferences (Closed)

Created:
6 years, 1 month ago by dgn
Modified:
6 years, 1 month ago
Reviewers:
Bernhard Bauer, aberent
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix getters for the printing preferences The getter for the printing.enabled preference was improperly testing for whether the property was managed. The value of the property and the managed status are now obtainable through separate functions BUG=423886 Committed: https://crrev.com/09df15868941e7489acff767e00864769ca6338b Cr-Commit-Position: refs/heads/master@{#302420}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
dgn
6 years, 1 month ago (2014-10-31 19:38:11 UTC) #2
dgn
6 years, 1 month ago (2014-10-31 19:39:09 UTC) #4
Bernhard Bauer
https://codereview.chromium.org/695773004/diff/1/chrome/browser/android/preferences/pref_service_bridge.cc File chrome/browser/android/preferences/pref_service_bridge.cc (right): https://codereview.chromium.org/695773004/diff/1/chrome/browser/android/preferences/pref_service_bridge.cc#newcode226 chrome/browser/android/preferences/pref_service_bridge.cc:226: static jboolean GetPrintingManaged(JNIEnv* env, jobject obj) { I don't ...
6 years, 1 month ago (2014-10-31 20:03:22 UTC) #5
Bernhard Bauer
Nevermind, just saw the corresponding downstream CL. LGTM
6 years, 1 month ago (2014-10-31 20:57:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695773004/1
6 years, 1 month ago (2014-11-03 10:23:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 11:03:42 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 11:04:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09df15868941e7489acff767e00864769ca6338b
Cr-Commit-Position: refs/heads/master@{#302420}

Powered by Google App Engine
This is Rietveld 408576698