Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 695773003: move import combinator suggestions into a separate computer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index 148b013867c104aa69b4de06b01aec3c8c72845b..941b3b7701674a05210e92e9deb3ce486c0c6646 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -1068,33 +1068,7 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
class X {}''');
computeFast();
return computeFull(true).then((_) {
- assertSuggestImportedClass(
- 'A',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedClass(
- 'B',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedClass(
- 'PB',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedTopLevelVar(
- 'T1',
- null,
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedFunction(
- 'F1',
- 'PB',
- false,
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertNotSuggested('C');
- assertNotSuggested('D');
- assertNotSuggested('X');
- assertNotSuggested('Object');
+ assertNoSuggestions();
});
}
@@ -1121,43 +1095,7 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
class X {}''');
computeFast();
return computeFull(true).then((_) {
- assertSuggestImportedClass(
- 'A',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedClass(
- 'B',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedClass(
- 'PB',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedTopLevelVar(
- 'T1',
- null,
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedFunction(
- 'F1',
- 'PB',
- false,
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedClass(
- 'Clz',
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertSuggestImportedFunctionTypeAlias(
- 'F2',
- null,
- false,
- CompletionRelevance.DEFAULT,
- CompletionSuggestionKind.IDENTIFIER);
- assertNotSuggested('C');
- assertNotSuggested('D');
- assertNotSuggested('X');
- assertNotSuggested('Object');
+ assertNoSuggestions();
});
}
@@ -1289,6 +1227,23 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
+ test_FormalParameterList() {
+ // FormalParameterList MethodDeclaration
+ addTestSource('''
+ foo() { }
+ void bar() { }
+ class A {a(^) { }}''');
+ computeFast();
+ return computeFull(true).then((_) {
+ assertSuggestLocalFunction('foo', null);
+ assertSuggestLocalMethod('a', 'A', null);
+ assertSuggestLocalClass('A');
+ assertSuggestImportedClass('String');
+ assertSuggestImportedFunction('identical', 'bool');
+ assertNotSuggested('bar');
+ });
+ }
+
test_ForStatement_body() {
// Block ForStatement
addTestSource('main(args) {for (int i; i < 10; ++i) {^}}');
@@ -1601,23 +1556,6 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
});
}
- test_FormalParameterList() {
- // FormalParameterList MethodDeclaration
- addTestSource('''
- foo() { }
- void bar() { }
- class A {a(^) { }}''');
- computeFast();
- return computeFull(true).then((_) {
- assertSuggestLocalFunction('foo', null);
- assertSuggestLocalMethod('a', 'A', null);
- assertSuggestLocalClass('A');
- assertSuggestImportedClass('String');
- assertSuggestImportedFunction('identical', 'bool');
- assertNotSuggested('bar');
- });
- }
-
test_MethodInvocation_no_semicolon() {
// MethodInvocation ExpressionStatement Block
addTestSource('''

Powered by Google App Engine
This is Rietveld 408576698