Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695753003: app_list: Decouple UpdateDriveApp from sync processing. (Closed)

Created:
6 years, 1 month ago by xiyuan
Modified:
6 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

app_list: Decouple UpdateDriveApp from sync processing. BUG=429205 Committed: https://crrev.com/9fb042ce95665932ed8be357cc75abbe0cc047cb Cr-Commit-Position: refs/heads/master@{#302327}

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : fix test attempt 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/apps/drive/drive_app_provider.cc View 1 chunk +16 lines, -2 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
xiyuan
PTAL. Thanks.
6 years, 1 month ago (2014-10-31 17:03:22 UTC) #2
stevenjb
lgtm
6 years, 1 month ago (2014-10-31 17:13:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695753003/1
6 years, 1 month ago (2014-10-31 17:21:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/1849)
6 years, 1 month ago (2014-10-31 18:14:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695753003/20001
6 years, 1 month ago (2014-10-31 18:54:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/7805) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/1904)
6 years, 1 month ago (2014-10-31 19:44:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695753003/40001
6 years, 1 month ago (2014-10-31 20:33:02 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-31 21:37:31 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 21:38:12 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9fb042ce95665932ed8be357cc75abbe0cc047cb
Cr-Commit-Position: refs/heads/master@{#302327}

Powered by Google App Engine
This is Rietveld 408576698