build/landmines.py - Issue 695753002: Add support for GYP_GENERATOR_FLAGS out dir setting for landmines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 695753002: Add support for GYP_GENERATOR_FLAGS out dir setting for landmines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Address review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index a03486499bba4b055881804d24915d2f8db80fd1..3afb4fda734d5278b9f0b8d79a86cd30e26d379f 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -44,7 +44,13 @@ def get_build_dir(build_tool, is_iphone=False):

if build_tool == 'xcode':

ret = os.path.join(SRC_DIR, 'xcodebuild')

elif build_tool in ['make', 'ninja', 'ninja-ios']: # TODO: Remove ninja-ios.

- ret = os.path.join(SRC_DIR, os.environ.get('CHROMIUM_OUT_DIR', 'out'))

+ output_dir = None

scottmg 2014/10/31 16:40:14 delete this line

+ if ('CHROMIUM_OUT_DIR' not in os.environ and

+ 'output_dir' in landmine_utils.gyp_generator_flags()):

+ output_dir = landmine_utils.gyp_generator_flags()['output_dir']

+ else:

+ output_dir = os.environ.get('CHROMIUM_OUT_DIR', 'out')

+ ret = os.path.join(SRC_DIR, output_dir)

else:

raise NotImplementedError('Unexpected GYP_GENERATORS (%s)' % build_tool)

return os.path.abspath(ret)

« no previous file with comments | « build/landmine_utils.py ('k') | no next file » | no next file with comments »