Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 695753002: Add support for GYP_GENERATOR_FLAGS out dir setting for landmines (Closed)

Created:
6 years, 1 month ago by oetuaho-nv
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Add support for GYP_GENERATOR_FLAGS out dir setting for landmines BUG=421894 Committed: https://crrev.com/6bad0d4fad0ee39e993d90eb2ab8050d650efa2b Cr-Commit-Position: refs/heads/master@{#302419}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Total comments: 1

Patch Set 3 : Remove unnecessary line as per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M build/landmine_utils.py View 1 chunk +6 lines, -0 lines 0 comments Download
M build/landmines.py View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
oetuaho-nv
Please review, I received no response to the bug report about this so I decided ...
6 years, 1 month ago (2014-10-31 10:30:06 UTC) #2
Sami
https://codereview.chromium.org/695753002/diff/1/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/695753002/diff/1/build/landmines.py#newcode49 build/landmines.py:49: output_dir = landmine_utils.gyp_generator_flags()['output_dir'] nit: rewriting this so that both ...
6 years, 1 month ago (2014-10-31 14:30:22 UTC) #4
oetuaho-nv
Addressed feedback in patch set 2.
6 years, 1 month ago (2014-10-31 15:06:50 UTC) #5
Sami
Thank you, lgtm.
6 years, 1 month ago (2014-10-31 15:10:01 UTC) #6
scottmg
lgtm https://codereview.chromium.org/695753002/diff/20001/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/695753002/diff/20001/build/landmines.py#newcode47 build/landmines.py:47: output_dir = None delete this line
6 years, 1 month ago (2014-10-31 16:40:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695753002/40001
6 years, 1 month ago (2014-11-03 08:29:50 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-03 09:10:04 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6bad0d4fad0ee39e993d90eb2ab8050d650efa2b Cr-Commit-Position: refs/heads/master@{#302419}
6 years, 1 month ago (2014-11-03 09:10:44 UTC) #11
Geoff Lang
6 years, 1 month ago (2014-11-03 14:50:11 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/697123002/ by geofflang@chromium.org.

The reason for reverting is: Win8 Release (NVIDIA) and Win8 Debug (NVIDIA) bots
are failing to delete temporary files in the hardware_accelerated_feature_tests.

Example failed build:
http://build.chromium.org/p/chromium.gpu/builders/Win8%20Debug%20%28NVIDIA%29...

BUG=429663.

Powered by Google App Engine
This is Rietveld 408576698