Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 695713002: Automatically open FSP mounted file systems. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Automatically open FSP mounted file systems. When opening an archive with the new ZIP unpacker based on the File System Provider API, we need to open on once it's mounted in the left nav. However, in the current design, we can't say if a newly mounted volume is a result of opening an archive. As a temporary workaround, this CL makes Files app open all FSP based volumes once they are mounted, but only in the focused window. TEST=Tested manually with the new ZIP unpacker. BUG=427776 Committed: https://crrev.com/1c9e1d8a79ec43dd347a63146d8d490b9757c9ca Cr-Commit-Position: refs/heads/master@{#302221}

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. I'm not proud of this solution. Please see the discussion in the bug ...
6 years, 1 month ago (2014-10-31 04:05:37 UTC) #2
hirono
lgtm!
6 years, 1 month ago (2014-10-31 04:14:42 UTC) #3
mtomasz
On 2014/10/31 04:14:42, hirono wrote: > lgtm! Thanks!
6 years, 1 month ago (2014-10-31 04:15:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695713002/20001
6 years, 1 month ago (2014-10-31 04:15:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 04:50:25 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 04:51:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c9e1d8a79ec43dd347a63146d8d490b9757c9ca
Cr-Commit-Position: refs/heads/master@{#302221}

Powered by Google App Engine
This is Rietveld 408576698