Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 695703002: Hotword Audio Verification App: UI Polishes (Closed)

Created:
6 years, 1 month ago by kcarattini
Modified:
6 years, 1 month ago
Reviewers:
rpetterson, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hotword Audio Verification App: UI Polishes Adds hi-res assets. Adds new error asset. Removes audio history step. Updates audio history 'learn more' link. BUG=390086 Committed: https://crrev.com/df55cf726a456223beb9cb72bc075eb41f44e3c8 Cr-Commit-Position: refs/heads/master@{#302407}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +14 lines, -9 lines 0 comments Download
M chrome/browser/resources/hotword_audio_verification/flow.js View 2 chunks +0 lines, -4 lines 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/bt-close-2x.png View Binary file 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/header-optin-2x.png View Binary file 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/ic-check-blue-2x.png View Binary file 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/ic-check-gray-2x.png View Binary file 0 comments Download
M chrome/browser/resources/hotword_audio_verification/images/ic-error-1x.png View Binary file 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/ic-error-2x.png View Binary file 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/mic-2x.png View Binary file 0 comments Download
A chrome/browser/resources/hotword_audio_verification/images/placeholder-loader-2x.png View Binary file 0 comments Download
D chrome/browser/resources/hotword_audio_verification/images/placeholder-loader-error-1x.png View Binary file 0 comments Download
M chrome/browser/resources/hotword_audio_verification/main.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/resources/hotword_audio_verification/steps/hotword_audio_history_step.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword_audio_verification/style.css View 1 4 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kcarattini
6 years, 1 month ago (2014-10-31 01:43:39 UTC) #2
rpetterson
lgtm
6 years, 1 month ago (2014-10-31 19:20:01 UTC) #3
Dan Beam
lgtm btw, I'm not sure the CQ works with binary files... if you need help ...
6 years, 1 month ago (2014-10-31 23:31:20 UTC) #4
kcarattini
Thanks! https://codereview.chromium.org/695703002/diff/1/chrome/browser/resources/hotword_audio_verification/style.css File chrome/browser/resources/hotword_audio_verification/style.css (right): https://codereview.chromium.org/695703002/diff/1/chrome/browser/resources/hotword_audio_verification/style.css#newcode47 chrome/browser/resources/hotword_audio_verification/style.css:47: url('../images/header-optin-1x.png') 1x, On 2014/10/31 23:31:20, Dan Beam wrote: ...
6 years, 1 month ago (2014-11-03 00:06:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695703002/20001
6 years, 1 month ago (2014-11-03 00:06:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-03 00:47:32 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 00:48:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df55cf726a456223beb9cb72bc075eb41f44e3c8
Cr-Commit-Position: refs/heads/master@{#302407}

Powered by Google App Engine
This is Rietveld 408576698