Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 695693002: Omnibox: Demote Bookmarklets without Title Matches (Closed)

Created:
6 years, 1 month ago by Mark P
Modified:
6 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Omnibox: Demote Bookmarklets without Title Matches For such a small change, I don't think we need to run an experiment. BUG=416148 Committed: https://crrev.com/11dcdcf9e5f469622c5f8b8d3050a0fbef982c73 Cr-Commit-Position: refs/heads/master@{#302225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/autocomplete/bookmark_provider.cc View 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark P
ptal
6 years, 1 month ago (2014-10-30 23:57:47 UTC) #2
Peter Kasting
LGTM
6 years, 1 month ago (2014-10-31 00:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695693002/1
6 years, 1 month ago (2014-10-31 04:08:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 04:59:53 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 05:01:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11dcdcf9e5f469622c5f8b8d3050a0fbef982c73
Cr-Commit-Position: refs/heads/master@{#302225}

Powered by Google App Engine
This is Rietveld 408576698